Skip to content

Backport false positive test fixes #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2017
Merged

Backport false positive test fixes #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
Package validator
================
<img align="right" src="https://raw.githubusercontent.com/go-playground/validator/v8/logo.png">
[![Join the chat at https://gitter.im/bluesuncorp/validator](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/go-playground/validator?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
![Project status](https://img.shields.io/badge/version-8.18.1-green.svg)
<img align="right" src="https://raw.githubusercontent.com/go-playground/validator/v8/logo.png">[![Join the chat at https://gitter.im/bluesuncorp/validator](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/go-playground/validator?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
![Project status](https://img.shields.io/badge/version-8.18.2-green.svg)
[![Build Status](https://semaphoreci.com/api/v1/projects/ec20115f-ef1b-4c7d-9393-cc76aba74eb4/530054/badge.svg)](https://semaphoreci.com/joeybloggs/validator)
[![Coverage Status](https://coveralls.io/repos/go-playground/validator/badge.svg?branch=v8&service=github)](https://coveralls.io/github/go-playground/validator?branch=v8)
[![Go Report Card](https://goreportcard.com/badge/github.com/go-playground/validator)](https://goreportcard.com/report/github.com/go-playground/validator)
Expand All @@ -11,9 +10,6 @@ Package validator

Package validator implements value validations for structs and individual fields based on tags.

### Announcement
Validator [v9.0.0 RC1](https://github.com/go-playground/validator/releases/tag/v9.0.0RC1) has been released, please let me know what you think [here](https://github.com/go-playground/validator/issues/250)

It has the following **unique** features:

- Cross Field and Cross Struct validations by using validation tags or custom validators.
Expand Down
8 changes: 4 additions & 4 deletions validator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4839,7 +4839,7 @@ func TestIsGt(t *testing.T) {
errs = validate.Field(tm, "gt")
Equal(t, errs, nil)

t2 := time.Now().UTC()
t2 := time.Now().UTC().Add(-time.Hour)

errs = validate.Field(t2, "gt")
NotEqual(t, errs, nil)
Expand Down Expand Up @@ -4875,7 +4875,7 @@ func TestIsGte(t *testing.T) {
errs := validate.Field(t1, "gte")
Equal(t, errs, nil)

t2 := time.Now().UTC()
t2 := time.Now().UTC().Add(-time.Hour)

errs = validate.Field(t2, "gte")
NotEqual(t, errs, nil)
Expand Down Expand Up @@ -4920,7 +4920,7 @@ func TestIsLt(t *testing.T) {
i := true
PanicMatches(t, func() { validate.Field(i, "lt") }, "Bad field type bool")

t1 := time.Now().UTC()
t1 := time.Now().UTC().Add(-time.Hour)

errs = validate.Field(t1, "lt")
Equal(t, errs, nil)
Expand Down Expand Up @@ -4957,7 +4957,7 @@ func TestIsLte(t *testing.T) {
i := true
PanicMatches(t, func() { validate.Field(i, "lte") }, "Bad field type bool")

t1 := time.Now().UTC()
t1 := time.Now().UTC().Add(-time.Hour)

errs := validate.Field(t1, "lte")
Equal(t, errs, nil)
Expand Down