Documentation fixes #304
Merged
Documentation fixes #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a few documentation issues I noticed. - Explain what Func is supposed to return. - Remove change reference to ActualNamespace to mention StructNamespace instead. - Remove references to Validatable, which no longer exists. - Fix godoc formatting. - Delete extra text from ReportValidationErrors comment. - Change ReportError interface definition so its arguments are named consistently with what they do.
Contributor
|
Thanks @aaronlehmann 👍 I'll merge and these changes will become public when I get to cutting the next release. |
fairyhunter13
added a commit
to fairyhunter13/validator
that referenced
this pull request
Jul 12, 2020
Documentation fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few documentation issues I noticed.
Funcis supposed to return.ActualNamespaceto mentionStructNamespaceinstead.
Validatable, which no longer exists.ReportValidationErrorscomment.ReportErrorinterface definition so its arguments are namedconsistently with what they do.
@go-playground/admins