Skip to content

Correct consecutive or logic #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2017
Merged

Correct consecutive or logic #330

merged 1 commit into from
Dec 13, 2017

Conversation

@deankarn
Copy link
Contributor

@deankarn deankarn commented Dec 13, 2017

This PR corrects checking of consecutive or blocks; the way it was checking for the end of an or validation block was incorrect.

NOTE: This bug only affected validation with consecutive or validation blocks eg.

block1 = tag1|tag2=
block2 = tag3|tag4
validate:"tag1|tag2=,tag3|tag4"

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

Fixes #329

@go-playground/admins

@deankarn deankarn self-assigned this Dec 13, 2017
@deankarn deankarn merged commit b1f51f3 into v9 Dec 13, 2017
@deankarn deankarn deleted the fix-consequtive-ors branch February 9, 2020 17:33
fairyhunter13 added a commit to fairyhunter13/validator that referenced this pull request Jul 12, 2020
@fairyhunter13
Correct consequtive or logic (go-playground#330)
ced5682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@deankarn deankarn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deankarn