Skip to content

Use NVARCHAR for string and text type #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Use NVARCHAR for string and text type #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions mssql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,8 @@ func mapColumn(column *rel.Column) (string, int, int) {
typ = "BIT"
case rel.Int:
typ = "INT"
// m = column.Limit
case rel.BigInt:
typ = "BIGINT"
// m = column.Limit
case rel.Float:
typ = "FLOAT"
m = column.Precision
Expand All @@ -135,14 +133,15 @@ func mapColumn(column *rel.Column) (string, int, int) {
m = column.Precision
n = column.Scale
case rel.String:
typ = "VARCHAR"
typ = "NVARCHAR"
m = column.Limit
if m == 0 {
m = 255
} else if m > 4000 {
m = 4000
}
case rel.Text:
typ = "TEXT"
m = column.Limit
typ = "NVARCHAR(MAX)"
case rel.Date:
typ = "DATE"
timeLayout = "2006-01-02"
Expand Down