Retries carry error to a success

[phillc]

Hello,

I have experienced this in my code base as have translated it to a test in the code base.

In this test case, I have an error (should be anything >399) on a json request with SetError for the first request, and then a successful second request.

I also have a retry condition that is looking for the first error

The result of the execution has the body of the second request, but the error of the first request.

I initially thought this was due to the err variable https://github.com/phillc/resty/blob/master/request.go#L611-L618 being shadowed, but fixing that did not fix the problem. I am currently in the process of debugging Backoff in hopes of finding it, but am currently not successful.

Any thoughts into if my usage is just wrong, or where the error likely is would be helpful.
Thanks.
Pull request with test coming.

[phillc]

I think this solves the problem, but I'm not 100% sure this is the right solution. 6572463

[jeevatkm]

@phillc It's a correct spot of resetting an error, the same request object is used for retry. Thanks, PR #209 is merged!