Skip to content

fix trace context overriding request context #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2019
Merged

fix trace context overriding request context #284

merged 1 commit into from
Nov 18, 2019

Conversation

@xixinjie
Copy link
Contributor

@xixinjie xixinjie commented Nov 17, 2019

No description provided.

@codecov
Copy link

codecov bot commented Nov 17, 2019 •
edited
Loading

Codecov Report

Merging #284 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   95.48%   95.48%           
=======================================
  Files           9        9           
  Lines        1152     1152           
=======================================
  Hits         1100     1100           
  Misses         29       29           
  Partials       23       23
Impacted Files Coverage Δ
trace.go 100% <100%> (ø) ⬆️
middleware.go 91.11% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b85655...e211102. Read the comment docs.

@xixinjie xixinjie mentioned this pull request Nov 17, 2019
Closed
jeevatkm
jeevatkm approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xixinjie Thank you for the PR to address an issue.

@jeevatkm jeevatkm added the bug label Nov 18, 2019
@jeevatkm jeevatkm merged commit e29360f into go-resty:master Nov 18, 2019
@xixinjie
Copy link
Contributor Author

xixinjie commented Nov 18, 2019

You're very welcome, thank you for sharing this awesome lib!

@jeevatkm jeevatkm added this to the v2.2.0 Milestone milestone Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeevatkm jeevatkm jeevatkm approved these changes

Assignees

@xixinjie xixinjie

Labels

bug

Milestone

v2.2.0 Milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xixinjie @jeevatkm