Skip to content

Conversation

@dan-rising
Copy link

Was working on a project recently that could have benefitted from something like this since the requests were constructed in a different place than they were actually sent.

You can already do this in Resty with something like this:

req := client.R()
req.URL = "http://httpbin.org/get"
req.Method = "GET"

resp, err := req.Execute(req.Method, req.URL)

It just feels a bit clunky to me.

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #286 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
+ Coverage   95.48%   95.49%   +<.01%     
==========================================
  Files           9        9              
  Lines        1152     1154       +2     
==========================================
+ Hits         1100     1102       +2     
  Misses         29       29              
  Partials       23       23
Impacted Files Coverage Δ
request.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e29360f...dc8cfaa. Read the comment docs.

Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dan-rising Thank you for the PR 👍

@jeevatkm jeevatkm merged commit 7a98801 into go-resty:master Jan 8, 2020
@jeevatkm jeevatkm added this to the v2.2.0 Milestone milestone Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants