Skip to content

Conversation

@ninedraft
Copy link
Contributor

Refactor sleepDuration function and use local random generatpr

@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #406 (621a643) into master (61f4307) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
+ Coverage   95.97%   96.01%   +0.03%     
==========================================
  Files          10       10              
  Lines        1019     1029      +10     
==========================================
+ Hits          978      988      +10     
  Misses         23       23              
  Partials       18       18              
Impacted Files Coverage Δ
retry.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f4307...621a643. Read the comment docs.

@ninedraft
Copy link
Contributor Author

@jeevatkm if you are not going to take this MR, please write. This will not offend me at all, I will just try to look for other places in your project where I could be useful!

@jeevatkm
Copy link
Member

jeevatkm commented Mar 1, 2021

Hello @ninedraft it's not like that. I really appreciate your contribution. Lately, I have been busy with a couple of projects in my day jobs. I'm not getting enough time. In the upcoming days, it will be alright. I will look at this PR this week. Thanks again!

@jeevatkm jeevatkm self-requested a review March 20, 2021 21:59
Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ninedraft Thanks for your PR and improving Resty.
I'm really sorry for the delay, due to personal reasons.

@jeevatkm jeevatkm merged commit 0b269e5 into go-resty:master Mar 20, 2021
@jeevatkm jeevatkm added this to the v2.6.0 Milestone milestone Mar 20, 2021
@ninedraft
Copy link
Contributor Author

thx!

@ninedraft ninedraft deleted the 1-refactor-retry branch March 21, 2021 08:42
@jeevatkm jeevatkm added the v2 For resty v2 label Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement v2 For resty v2

Development

Successfully merging this pull request may close these issues.

2 participants