Port gdey/quad-edge based triangulation #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [geom] Triangle was not getting written because it system did not know how to store it. Made it act like a polygoner, by giving it a LinearRings method. * [debugger] Added filename atrribute to recorder * [debugger] Cleaned up log output by guarding it with debug
* Got the top level dir converted over to not use `quadedge/geometry` package.
Ported over subdivision triangulation.
Pull Request Test Coverage Report for Build 236
💛 - Coveralls |
Debugger needs cgo to work. More the recorder is geopackage which requires cgo. So, only initialize the debugger when cgo is enabled.
ARolek
approved these changes
Aug 11, 2019
Changed ReplaceAll with Replace, as replace all was introduced in 1.12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code only does the triangulation using geom library and structures.