Skip to content

Conversation

pd93
Copy link
Member

@pd93 pd93 commented Jun 11, 2023

Note: This depends on #1214

Implements a draft version of the gentle force experiment. Based on the experiments branch and PR.

This works by adding a new field to the taskfile.Call struct called Direct which is only set when a task is called directly from the CLI. Another new field is added to the Executor called ForceAll. Depending on whether or not the experiment is enabled, we set the Executor's Force and ForceAll fields and then we will skip fingerprinting if the task is direct and the executor is set to force, OR if the executor is set to force all.

Copy link
Member

@andreynering andreynering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👏 👏 👏

Base automatically changed from experiments to main June 18, 2023 01:04
@pd93 pd93 merged commit 5fdaa9a into main Jun 18, 2023
@pd93 pd93 deleted the gentle-force branch June 18, 2023 01:32
@pd93 pd93 mentioned this pull request Jul 19, 2023
@pd93 pd93 linked an issue Jul 19, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gentle force experiment

2 participants