Release v5.10.10 #551
Merged
Release v5.10.10 #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port-cacheable-requests-in-api-base
The filter is applied in the API base class because the request class itself has no access to the plugin instance, which is required to scope the filter to the plugin.
The new filters around cache lifetime and whether a request is cacheable are more suitable for disabling or debugging request caching.
This will allow correctly caching GET requests as well as prevent issues where a POST request with the exact same body is made to 2 different endpoints, and a cached response from the first endpoint is returned.
Co-authored-by: Chase Wiseman <chase@skyverge.com>
…hub.com:skyverge/wc-plugin-framework into mwc-2478/support-cacheable-requests-in-api-base
…trait Add cacheable request trait
…ests-in-api-base Support cacheable requests in API base class
ChaseWiseman
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Release branch for v5.10.10
Individual PRs should branch off from master so they can be tested without updating the FW namespace from individual plugins (out of convenience).
PRs