Skip to content

Input Primitive PDR#30

Merged
amarques-godaddy merged 4 commits intomainfrom
input-primitive-pdr
Nov 11, 2025
Merged

Input Primitive PDR#30
amarques-godaddy merged 4 commits intomainfrom
input-primitive-pdr

Conversation

@amarques-godaddy
Copy link
Copy Markdown
Contributor

@amarques-godaddy amarques-godaddy requested a review from a team as a code owner November 5, 2025 23:36
Copilot AI review requested due to automatic review settings November 5, 2025 23:36
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 5, 2025

⚠️ No Changeset found

Latest commit: cae2cec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a Product Design Review (PDR) document for a new Input primitive component in the Bento design system. The Input primitive is designed to be a headless, accessible foundation for all HTML input types, built on React Aria and Bento's slot system.

Key changes:

  • Comprehensive PDR document covering architecture, accessibility, and implementation patterns for a universal Input primitive
  • Detailed specification of slot-based architecture with data attributes for styling hooks
  • Type-specific prop filtering system to handle different HTML input types appropriately

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/pdrs/input-primitive.mdx Outdated
Comment thread docs/pdrs/input-primitive.mdx Outdated
amarques-godaddy and others added 2 commits November 5, 2025 15:36
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
<Input
type="text"
value={value}
onChange={e => setValue(e.target.value)}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a case for exposing this as a native listener callback over the cb(updateValue, metaObject) signature? This has been generally helpful on placing the setter directly on the onChange.

function ControlledInputExample() {
  const [value, setValue] = React.useState('');
  return (
    <Input
      type="text"
      value={value}
       onChange={setValue}
    />
  );
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This opens up a good discussion for setting a general pattern for all Bento primitives. I intended this to simply be forwarded attributes that we don't modify internally in order to minimize API differences between our primitive and the native input but I'm interested in hearing thoughts from the rest of the team.

Comment thread docs/pdrs/input-primitive.mdx Outdated
Comment thread docs/pdrs/input-primitive.mdx
@amarques-godaddy amarques-godaddy merged commit 7d169e9 into main Nov 11, 2025
3 checks passed
@akazemier-godaddy akazemier-godaddy deleted the input-primitive-pdr branch November 14, 2025 23:13
@amarques-godaddy amarques-godaddy mentioned this pull request Nov 20, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants