Skip to content
This repository was archived by the owner on Oct 21, 2025. It is now read-only.

Conversation

@Fishrock123
Copy link
Contributor

  • rustfmt formatting
  • clippy linting
  • Use .map_err() instead of match where appropriate.
  • Removed some intermediately utf8 validation (i.e bytes->str->json is now bytes->json).
    • Use temp_to_vector where possible instead of temp_to_string.
  • Removed some unnecessary memcopys
    • Avoid .to_vec().
    • Uses std::borrow::Cow to avoid another vector allocation.
  • Uses implicit return when appropriate.

Update based on rust 1.62

- rustfmt formatting
- clippy linting
- Use `.map_err()` instead of `match` where appropriate.
- Removed some intermediately utf8 validation (i.e bytes->str->json is now bytes->json).
    - Use `temp_to_vector` where possible instead of `temp_to_string`.
- Removed some unnecessary `memcopy`s
    - Avoid `.to_vec()`.
    - Uses `std::borrow::Cow` to avoid another vector allocation.
- Uses implicit return when appropriate.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jgowdy jgowdy merged commit c83acd3 into godaddy:main Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants