-
Notifications
You must be signed in to change notification settings - Fork 48
keep currency in minor units and convert using new currency util #1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+544
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for all currencies
🦋 Changeset detectedLatest commit: 485586e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…rency-internationalization
…rency-internationalization
wcole1-godaddy
approved these changes
Nov 13, 2025
Contributor
wcole1-godaddy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
refactor: standardize currency handling with formatCurrency utility
Replace all manual currency conversions (/ 100, * 100, .toFixed(), Intl.NumberFormat)
with the centralized formatCurrency utility to ensure consistent precision handling
across different currencies (USD, VND, etc.) and eliminate hardcoded "USD" references.
All values from the API now remain in minor units (cents) throughout the application,
with formatCurrency handling display conversions based on currency-specific precision.
BREAKING CHANGE: checkout-transformers now keeps originalPrice/price in minor units
instead of major units. All currency display must use formatCurrency.
Files Changed (11 files)
Core Utilities
Form Components
Display Components
Payment Components
Express Checkout
How to Test
All currency displays should look identical to before:
Test with USD (2 decimals)
Test with other currencies if available
Checkout Flow
✓ Line item prices
✓ Subtotal
✓ Taxes (if enabled)
✓ Shipping options
✓ Discount codes
✓ Tips (if enabled)
✓ Final total
Tips Feature
✓ Tip amounts calculate correctly
✓ Display format is correct
✓ Value displays correctly
✓ Converts to minor units correctly
Express Checkout (Apple Pay, Google Pay, PayPal)
✓ Shipping costs display correctly
✓ Tax calculation works
✓ Discount displays correctly
✓ Total updates correctly
✓ Payment processes with correct amounts
Changeset
Test Plan
PAZE:
GPay
PayPal:
Order:
Shipping: