Skip to content

Conversation

@DullReferenceException
Copy link

  • Enable eslint@6
  • Fix peerDependencies to align with devDependencies
  • Remove unused dependency

- Enable `eslint@6`
- Fix peerDependencies to align with devDependencies
- Remove unused dependency
"eslint": "^5.8.0",
"eslint-plugin-json": "^1.2.0",
"eslint-plugin-mocha": "^5.2.0"
"eslint": "^6.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this change across all the packages at once?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I can do that, sadly. The problem is that some of these packages have dependencies on other packages in this repo, and those packages have eslint peer dependencies which would be disallowed. So I'm going to have to publish this one first, then update those dependent on it afterward (in fact, I've got one queued up that does just that).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do a major version bump of this library, then consumers who want ESlint5 can remain on the previous version, right?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scommisso: that's the plan, to make this a major bump (going to do that post-merge).

@DullReferenceException DullReferenceException merged commit 30488ad into godaddy:master Aug 13, 2019
@DullReferenceException DullReferenceException deleted the eslint-6-support branch August 13, 2019 22:03
wcole1-godaddy pushed a commit that referenced this pull request Oct 13, 2025
- Enable `eslint@6`
- Fix peerDependencies to align with devDependencies
- Remove unused dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants