Update runtime_version to use non-deprecated get_godot_version pointer.

[Yarwin]

get_godot_version has been deprecated in favor of get_godot_version2: https://github.com/godotengine/godot/blob/master/core/extension/gdextension_interface.h#L854.

I could leave it as good first issue, oh well 😬.

[GodotRust]

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1394

[Bromeon]

Thanks a lot! 👍

I could leave it as good first issue, oh well 😬.

We can't always leave things open in the hope that someone will pick them up one day. Many such issues are open for more than a year.

[Bromeon]

Please don't prefix anything we define with GDExtension.

If we do this in other places, we should fix it.

[Bromeon]

Should be const and not static. See also next comment with grouping 🙂

[Bromeon]

Would be nice to define this in the other file, next to the function pointer type, and re-export here.

If we keep all 3 symbols (func ptr, func name, version struct) together, it might also be worth an immediately re-exported module:

#[cfg(before_api = "4.5")]
mod version_symbols {
    pub ...
}
#[cfg(since_api = "4.5")]
mod version_symbols {
    pub ...
}
use version_symbols::*;

[Bromeon]

Sorry, forgot to add this before:

I was thinking to add a high-level GodotVersion at some point, which could be used by GdextBuild or similar. In anticipation of that, would it make sense to include "Sys" here? Also in the function pointer, then we can drop the "Interface":

Suggested change

	pub type GodotVersion = GDExtensionGodotVersion;
	pub type InterfaceGetGodotVersion = GDExtensionInterfaceGetGodotVersion;
	pub type GodotSysVersion = super::GDExtensionGodotVersion;
	pub type GetGodotSysVersion = super::GDExtensionInterfaceGetGodotVersion;

(Not sure if use super::* is still needed)

[Bromeon]

Thanks!