Skip to content

Prevent procedural macro hygiene issue with eager macros #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2025
Merged

Prevent procedural macro hygiene issue with eager macros #1397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions godot-macros/src/class/data_models/func.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,9 @@ fn make_forwarding_closure(
};

quote! {
|instance_ptr, params| {
// Identifiers need to share the span to avoid proc macro hygiene issues
// similar to https://github.com/godot-rust/gdext/pull/1397.
|instance_ptr, #param_ident| {
let #params_tuple #sig_tuple_annotation = #param_ident;

let storage =
Expand All @@ -409,7 +411,9 @@ fn make_forwarding_closure(
};

quote! {
|instance_ptr, params| {
// Identifiers need to share the span to avoid proc macro hygiene issues
// similar to https://github.com/godot-rust/gdext/pull/1397.
|instance_ptr, #param_ident| {
// Not using `virtual_sig`, since virtual methods with `#[func(gd_self)]` are being moved out of the trait to inherent impl.
let #params_tuple #sig_tuple_annotation = #param_ident;

Expand All @@ -423,8 +427,11 @@ fn make_forwarding_closure(
}
ReceiverType::Static => {
// No before-call needed, since static methods are not virtual.
//
// Identifiers need to share the span to avoid proc macro hygiene issues
// similar to https://github.com/godot-rust/gdext/pull/1397.
quote! {
|_, params| {
|_, #param_ident| {
let #params_tuple = #param_ident;
#class_name::#method_name(#(#params),*)
}
Expand Down
Loading