Fix get_godot_version2 unavailable on older builds
#1403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks for availability of both `get_godot_version` and `get_godot_version2` function pointers to obtain runtime version. This works for versions < 4.5 and >= 4.5, and both normal and no-deprecated-symbol builds of Godot. Also fixes a bug during init logic where `GDExtensionGodotVersion2` was used in some cases, although this one would *always* be `GDExtensionGodotVersion` for Godot 4.0.
Bromeon
added
bug
c: ffi
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1403 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks for availability of both
get_godot_versionandget_godot_version2function pointers to obtain runtime version. This works for versions < 4.5 and >= 4.5, and both normal and no-deprecated-symbol builds of Godot.Also fixes a bug during init logic where
GDExtensionGodotVersion2was used in some cases, although this one would always beGDExtensionGodotVersionfor Godot 4.0.Fixes #1398.