Add GString::chars for 4.1
#714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-714 |
Bromeon
reviewed
May 15, 2024
Member
There was a problem hiding this comment.
Thanks a lot for this!
It would be nice if the API >= 4.1 would deprecate and not remove the old names, with a short explanation like:
Renamed to chars(). No longer checked + unchecked overloads, because Godot 4.1 ensures valid UTF-32.\nFor details, see #714.
(I hope that's actually true, didn't check all angles here)...
You can use #[cfg_attr(..., deprecated(...))] for this.
joriskleiber
force-pushed
the
add-gstring-chars
branch
from
e4ea57d to
f406985
Compare
Bromeon
added
quality-of-life
lilizoey
reviewed
May 15, 2024
joriskleiber
force-pushed
the
add-gstring-chars
branch
from
f406985 to
4aaae81
Compare
Bromeon
reviewed
May 16, 2024
Member
Bromeon
left a comment
Bromeon
left a comment
There was a problem hiding this comment.
Thanks for the update! Only few things left 😉
…ring::chars` for 4.1
joriskleiber
force-pushed
the
add-gstring-chars
branch
from
4aaae81 to
9bba7b8
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
|
This race condition is truly annoying... 🙄 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 20, 2024
Add `GString::chars` for 4.1
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
GString::charsfor 4.1 and hidesGString::chars_checked/GString::chars_uncheckedmay close #712