LineEdit Right-Click clearing selection

[madmiraal]

Godot version

3.x (99c07c9)

System information

Ubuntu 21.10

Issue description

In LineEdit, when text is selected, you can no longer right-click and cut or copy the selected text, because, when right-clicking, the selection is cleared.

This affects 3.5-beta2 and beta3, it works fine in 3.4.4, 3.5-beta1 and master.

Steps to reproduce

In a LineEdit, select some text, then try right-click and cut or copy the selected text.

Minimal reproduction project

RightClickCut.zip

[madmiraal]

Git bisect points to 0ffacff #54353 cc @ConteZero

[ConteZero]

When right-clicking a NOTIFICATION_FOCUS_EXIT is received and this code is executed:

if (deselect_on_focus_loss_enabled) {
	deselect();
}

This does not happens on master branch, so I don't know if this is a bug on 3.x branch or not.

I think that the correct behavior is to NOT send the NOTIFICATION_FOCUS_EXIT when right-clicking, all the program that I've tested do not lose field focus when you right click on it.

[madmiraal]

LineEdit receives a NOTIFICATION_FOCUS_EXIT, because the PopupMenu that the right-click creates grabs the focus:

godot/scene/gui/popup.cpp

Line 187 in fa9b77d

focusable->grab_focus();

So receiving a NOTIFICATION_FOCUS_EXIT is not a bug in 3.x. It just works very differently than in 4.0.

If this isn't easily fixable, we should revert 0ffacff.

[ConteZero]

I've already tried to comment line 187 on popup.cpp but the the NOTIFICATION_FOCUS_EXIT continues to be received from LineEdit when right-clicking.

Anyway I've coded a workaround that should avoid the text deselection.

[akien-mga]

Fixed by #59827.