Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSAO doesn't work in viewport with transparent bg #70670

Open
Handagotes opened this issue Dec 28, 2022 · 8 comments
Open

SSAO doesn't work in viewport with transparent bg #70670

Handagotes opened this issue Dec 28, 2022 · 8 comments

Comments

@Handagotes
Copy link

Godot version

3.5.1.stable

System information

Windows 10, GLES3, GTX 1070ti

Issue description

Turning on 'Transparent BG' property in viewport with 3D objects in it disables the SSAO effect.
0
1

Steps to reproduce

  1. In newly created scene add TextureRect or Sprite with any texture;
  2. Add ViewportContainer with Viewport;
  3. Create simple 3D scene in viewport with floor, cube and сamera;
  4. Create Environment for camera with ProceduralSky and SSAO turned on;
  5. Launch project and turn on transparent bg for viewport.

Minimal reproduction project

ssao test.zip

@Chaosus Chaosus added this to the 4.0 milestone Dec 28, 2022
@Chaosus Chaosus removed this from the 4.0 milestone Dec 28, 2022
@BastiaanOlij
Copy link
Contributor

Please try this with #72838 applied, it works for me in my test scene:
image

@BastiaanOlij BastiaanOlij linked a pull request Feb 9, 2023 that will close this issue
@Handagotes
Copy link
Author

Handagotes commented Feb 9, 2023

@BastiaanOlij I can't reproduce this bug on any 4.0 beta build. Is it possible to apply your PR to 3.5?

@Calinou
Copy link
Member

Calinou commented Feb 9, 2023

@BastiaanOlij I can't reproduce this bug on any 4.0 beta build. Is it possible to apply your PR to 3.5?

The SSAO implementation in 4.0 is entirely different from the one in 3.5 (along with the rendering backend), so no.

@Handagotes
Copy link
Author

Unlink PR then please.

@Zireael07
Copy link
Contributor

@Handagotes Not possible in github afaik

@Handagotes
Copy link
Author

@Zireael07 will I be able to reopen this issue when PR will be merged?

@akien-mga akien-mga added this to the 3.x milestone Feb 9, 2023
@Handagotes
Copy link
Author

@akien-mga thanks

@BastiaanOlij
Copy link
Contributor

The SSAO implementation in 4.0 is entirely different from the one in 3.5 (along with the rendering backend), so no.

Oops, sorry I went through so many PRs yesterday to see which ones were related, I missed this one was 3.5..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants