Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree focus StyleBox is drawn outside of bounds #88749

Open
Maran23 opened this issue Feb 24, 2024 · 3 comments
Open

Tree focus StyleBox is drawn outside of bounds #88749

Maran23 opened this issue Feb 24, 2024 · 3 comments

Comments

@Maran23
Copy link
Contributor

Maran23 commented Feb 24, 2024

Tested versions

  • Godot 4.2.1
  • Godot v4.3.dev3

System information

Godot v4.3.dev3 - Windows 10.0.19045 - Vulkan (Forward+) - dedicated AMD Radeon RX 6900 XT (Advanced Micro Devices, Inc.; 31.0.24002.92) - AMD Ryzen 9 5900X 12-Core Processor (24 Threads)

Issue description

When exploring the Theme and clicking inside the Tree node, the focus StyleBox is drawn outside of the bounds, overlapping with the Godot editor.

image

Steps to reproduce

  1. Create a new theme
  2. Click inside the Tree node
  3. Verify the focus StyleBox

Minimal reproduction project (MRP)

theme.zip

@Santoss1809
Copy link
Contributor

Santoss1809 commented Apr 1, 2024

Hi I'm a student, currently completing a course where i need to solve an issue for an open source project and I chose godot .I have managed to solve this issue by removing the canvas_item_add_clip_ignore on the has_focus if block the Focus Style Box does not clip anymore and is the same has the TextEdit. Is this as intended? Because the StyleBox seems to be behind the panel for some reason. Its just asthetics i dont know if this is relevant for this issue or not.
image

@Calinou
Copy link
Member

Calinou commented Aug 7, 2024

Is this as intended? Because the StyleBox seems to be behind the panel for some reason. Its just asthetics i dont know if this is relevant for this issue or not.

The canvas_item_add_clip_ignore() calls in question have always been present in Godot, even from its very first open source commit:

image

I don't know exactly what it's needed for.

@Maran23
Copy link
Contributor Author

Maran23 commented Sep 1, 2024

Drawing the focus style outside of the clip sounds wrong. It is very rarely used in the project. Probably worth to check if it can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants