Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double clicking on variable names followed by assignment or compare operators, includes the right side value #91964

Closed
wyattbiker opened this issue May 14, 2024 · 5 comments · Fixed by #92514

Comments

@wyattbiker
Copy link

Tested versions

v4.3.dev6.official [64520fe]

System information

Linux Kubuntu 23.04 KDE Plasma Version: 5.27.4 KDE Frameworks Version: 5.104.0 Qt Version: 5.15.8

Issue description

In Dev 6, Double clicking on variable names followed by assignment or compare operators, includes the right side value.
if there is no space separator between them/
Works correctly in dev 5

Steps to reproduce

Example screen shots
Double click on str highlights past the assignment
image

Double click on major highlights past the compare
image

Minimal reproduction project (MRP)

see screen shots

@akien-mga
Copy link
Member

CC @kitbdev - didn't bisect but I suspect it could be one of your TextEdit changes.

@kitbdev
Copy link
Contributor

kitbdev commented May 15, 2024

I think it was caused by:

Apparently a virtual space grapheme was used to separate them, but virtual graphemes are now skipped. It also isn't considered punctuation.

@akien-mga
Copy link
Member

CC @bruvzg

@wyattbiker
Copy link
Author

Heya wanted to add that this happens if you click on the right hand value as well.

E.g.
code=0123
So if you click on 0123 it will also highlight code

How much code was changed to cause this issue? I guess I am just saying maybe revert back this particular issue for now, so we can keep testing 6 without much fuss.

@wyattbiker
Copy link
Author

I hope this makes it through into the beta. It's PITA trying to write code.

@akien-mga akien-mga moved this from Not Critical to Bad in 4.x Release Blockers Jun 11, 2024
@akien-mga akien-mga changed the title Dev 6: Double clicking on variable names followed by assignment or compare operators, includes the right side value Double clicking on variable names followed by assignment or compare operators, includes the right side value Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Bad
Development

Successfully merging a pull request may close this issue.

4 participants