Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate track action added #24210

Closed
wants to merge 1 commit into from

Conversation

PedroHugoNoevo
Copy link

This solves issue #15029

https://i.imgur.com/uo3pAFY.png

https://i.imgur.com/xyhg2h6.png

https://i.imgur.com/aI5rLtW.png

@akien-mga
Copy link
Member

Done

Please amend your commit log to be more explicit, this doesn't tell us anything about what the commit implements. It should read something like:

Add duplicate track action to AnimationPlayer

Fixes #15029.

See https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-logs-with-readability-in-mind and PR workflow.

@akien-mga
Copy link
Member

There are also some style issues: https://travis-ci.org/godotengine/godot/jobs/464914837

You can use clang-format to make sure your code style matches our guidelines.

@akien-mga
Copy link
Member

akien-mga commented Dec 12, 2018

Moving to 3.2 milestone as we're about to enter the beta stage and release freeze for Godot 3.1. Only bug fixes against issues of the 3.1 milestone (or enhancements to core features of the 3.1 roadmap) will be considered until 3.1-stable is released.

Note: If it's merged after 3.1-stable is released, this change may be considered for cherry-picking into a later 3.1.x release.

@akien-mga akien-mga modified the milestones: 3.1, 3.2 Dec 12, 2018
@Calinou
Copy link
Member

Calinou commented Nov 22, 2019

@PedroHugoNoevo Bump 🙂 If you still want this to be merged, you'll need to make the changes described above (and solve merge conflicts). See PR workflow for details.

@jahd2602
Copy link
Contributor

Duplicate of #35804

@Calinou
Copy link
Member

Calinou commented Jan 31, 2020

I'll close this due to inactivity. @jahd2602 made a new pull request based on yours with the merge conflicts solved. Thanks for your contribution anyway 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants