Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button in Project Manager to remove all missing projects #25713

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

qarmin
Copy link
Contributor

@qarmin qarmin commented Feb 8, 2019

This PR add a button to automatically delete missing projects.
Once the missing projects have been removed, a short summary appears in the console.
When there is no more empty projects, then button become disabled.

EDIT: Button now is not visible instead disabled, when there is not missing projects
EDIT2: Added break, when found first project, to not do empty iterations

Before clicking at button:
zrzut ekranu z 2019-02-11 17-47-12

After clicking at button:
zrzut ekranu z 2019-02-11 17-48-15

@Calinou
Copy link
Member

Calinou commented Feb 8, 2019

I suggest hiding the button entirely if there are no missing projects listed, as it cannot appear while the project manager is open.

@qarmin qarmin force-pushed the remove_all_missing_projects branch from 4cc34cc to 4fa843a Compare February 8, 2019 21:50
@akien-mga
Copy link
Member

I don't see much use for this feature, it's quite rare to have missing projects unless you do a lot of engine testing like you do. And even then, you can do multi-select to remove several projects at once with Del or the "Delete" button. So I don't think it's worth adding 70+ lines of code for this.

@groud
Copy link
Member

groud commented Feb 10, 2019

I think the feature is ok, that happens often to me to have to clean a lot of imported projects (happends for the demo ones). The thing is that it takes the same space as the other more important buttons, while it stay something quite unusual.

In a rework of the project manager, I would rather have this buried somewhere in a menu, but until then, I think it is ok to have it as a button.

@girng
Copy link

girng commented Feb 11, 2019

straggler projects get greyed out and you can also hold shift or ctrl and select multiple projects, then click remove

@KoBeWi
Copy link
Member

KoBeWi commented Feb 20, 2019

I don't see much use for this feature, it's quite rare to have missing projects unless you do a lot of engine testing like you do.

There's also a possibility that you have to work on another PC and copy your editor settings, which happens to have saved project list. That's quite rare too, but happened to me enough times to create the original issue.

@fire
Copy link
Member

fire commented Mar 6, 2019

@Chaosus 's ui is more clean.

It solves the problem with choosing the exact projects.

clean

@akien-mga akien-mga merged commit 1b08ba1 into godotengine:master Apr 30, 2019
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants