Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix: Wrong unreachable warning after returning from match's wildcard pattern #25955 #26097
The parser only checked if the catch-all branch has a return in order to determine if the entire match block has a return.
This code block was assumed to always return.
This in turn means that every code following was regarded unreachable.
Every match is assumed to have a return, unless we find one branch to not return.
Feb 20, 2019
Looks good to me.
I noticed that the email you used to commit is not attached to your GitHub account. It does not prevent merging, but the contribution won't be associated with your GH account, so you won't be labeled as contributor in the GH interface. If you want to fix that you can either add the email of the commit to your account or change the email in the commit by amending it.