Fix: Wrong unreachable warning after returning from match's wildcard pattern #25955

[danielspaniol]

Fixes #25955

Problem

The parser only checked if the catch-all branch has a return in order to determine if the entire match block has a return.

This code block was assumed to always return.

match value:
    "test":
        print("test")
    _:
        return

This in turn means that every code following was regarded unreachable.

Solution

Every match is assumed to have a return, unless we find one branch to not return.

[bojidar-bg]

LGTM

[vnen]

Looks good to me.

I noticed that the email you used to commit is not attached to your GitHub account. It does not prevent merging, but the contribution won't be associated with your GH account, so you won't be labeled as contributor in the GH interface. If you want to fix that you can either add the email of the commit to your account or change the email in the commit by amending it.

[akien-mga]

Thanks!

[akien-mga]

Cherry-picked for 3.1.1.

[aburg]

the "unreachable code" warning still gets throws for the following script (v3.1.1.stable.official):

extends Node2D

func _ready():
	var selector = 0
	match selector:
		1:
			return
	
	print("we reached the unreachable")

warning output:

W 0:00:00:0586   Unreachable code (statement after return) in function '_ready()'.
  <Source>       Node2D.gd:9

output:

** Debug Process Started **
OpenGL ES 3.0 Renderer: GeForce GTS 450/PCIe/SSE2
we reached the unreachable

can you reopen this issue? or should i create a new one? o.0

[akien-mga]

Please open a new issue.