Scale environment light properly in GLES3 #29016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
force-pushed
the
env_light_fix
branch
2 times, most recently
from
43488e2
to
7ebcb62
Compare
clayjohn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #29008
Might fix: #27322
Does not affect: #21680 (nor should it)
Nullifies the fix here #28891. The fix was a little too hasty, I should have taken the time to fully resolve the underlying issue. For the record, the issue was failing to take GI into account when scaling the environmental reflection term in the brdf. When I made #27898 I only moved up the code for reflection probes, I forgot to move up the code for GI probes. This PR corrects that and all should be well now.