Separate culling state management from material state in GLES2 #29236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akien-mga Im gonna need some help with the ci on this one. Is the error something I could have caused? |
|
That's just a random timeout, I restarted the build job. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets culling state separately from material and includes
mirrorproperty in culling operation.This change is necessary because when an object is given a negative size the culling operation needs to be mirrored, however, GLES2 only updated the culling state when there was a change in material. So if two objects used the same material (e.g. the default SpatialMaterial) but one had a negative scale, the second one to be drawn would have culling flipped.
Fixes: #27900 and
Partly fixes: #26627 (includes a few unrelated issues), #25696 (still needs fix for when cull is disabled) and #26710 (still needs fix for when cull is disabled)