Disabled trim and normalize as default for wav import #31791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Highly support this change, audio files should not be trimmed or normalized without an explicit decision to do so. |
|
Judging by #24177, it seems this shouldn't break existing projects after all. |
|
@reduz agrees with the change, and it makes sense to me too that those options are opt-in, so let's merge. |
|
Thanks! @Calinou Should go in the changelog of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28728
Note that the issue is still labelled as Discussion, I just thought I would do the small changes so it can be merged or discarded as soon as the discussion comes to an end.