Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shadow color in GLES2 by making sRGB #34367

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Fix shadow color in GLES2 by making sRGB #34367

merged 1 commit into from
Dec 16, 2019

Conversation

clayjohn
Copy link
Member

Fixes: #27290

GLES2 renders in sRGB space, so the color should have been sRGB.

@clayjohn clayjohn added this to the 3.2 milestone Dec 15, 2019
@clayjohn clayjohn requested a review from reduz as a code owner December 15, 2019 18:28
@akien-mga akien-mga merged commit c39aa2b into godotengine:master Dec 16, 2019
@akien-mga
Copy link
Member

Thanks!

@clayjohn clayjohn deleted the GLES2-shadow_color branch January 31, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reduz reduz Awaiting requested review from reduz

Assignees
No one assigned
Labels
bug topic:rendering
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

GLES2 shadows are much darker than GLES3
2 participants
@clayjohn @akien-mga