Fix debugger crash inspecting freed object. #36532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be the correct way to validate a reference. Why is cast_to failing? Is this the correct way of checking if the object is valid?
akien-mga
added
the
cherrypick:3.x
|
Thanks! |
|
@akien-mga see this branch for the cherry-pick (the file is deleted in master): |
|
I was going to ask for the fix to make it into a point release, but I see it's being considered for it, if you're cherry-picking? |
|
Cherry-picked for 3.2.1. |
akien-mga
removed
the
cherrypick:3.x
This was referenced May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be the correct way to validate a reference.
Why is cast_to failing? Is this the correct way of checking if the object is valid? (@reduz ).
Fixes #36486
Likely fixes #29533
Minimal reproduction project: proj_dbg_crash.zip
Just run the project, wait till you get a breakpoint (after 4 secs) and while breaked open the remote tree tab. You will get the crash without this PR. Should work normally with this patch.