Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debugger crash inspecting freed object. #36532

Merged
merged 1 commit into from Feb 25, 2020

Conversation

@Faless
Copy link
Contributor

Faless commented Feb 25, 2020

This seems to be the correct way to validate a reference.
Why is cast_to failing? Is this the correct way of checking if the object is valid? (@reduz ).

Fixes #36486
Likely fixes #29533

Minimal reproduction project: proj_dbg_crash.zip
Just run the project, wait till you get a breakpoint (after 4 secs) and while breaked open the remote tree tab. You will get the crash without this PR. Should work normally with this patch.

This seems to be the correct way to validate a reference.
Why is cast_to failing? Is this the correct way of checking if the
object is valid?
@Faless Faless added this to the 4.0 milestone Feb 25, 2020
@akien-mga akien-mga merged commit dace1ec into godotengine:master Feb 25, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Feb 25, 2020

Thanks!

@Faless

This comment has been minimized.

Copy link
Contributor Author

Faless commented Feb 25, 2020

@akien-mga see this branch for the cherry-pick (the file is deleted in master):
https://github.com/Faless/godot/tree/debugger/weakref_crash_32

@Zireael07

This comment has been minimized.

Copy link
Contributor

Zireael07 commented Mar 3, 2020

I was going to ask for the fix to make it into a point release, but I see it's being considered for it, if you're cherry-picking?

@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Mar 4, 2020

Cherry-picked for 3.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.