Increase the default AudioStreamPlayer3D unit size to 10 #38224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
increase-audiostreamplayer3d-unit-size
branch
from
df25d7a
to
fd8d1d6
Compare
Calinou
changed the title
This makes it easier to hear sound while setting up the node. Since this changes the default value, this may break existing projects slightly. This also tweaks the Unit Size editor property hint for better usability. See discussion in godotengine#25468.
Calinou
force-pushed
the
increase-audiostreamplayer3d-unit-size
branch
from
fd8d1d6
to
87d107b
Compare
akien-mga
approved these changes
Jun 3, 2021
|
@reduz suggests that we should probably make a better editor for the attenuation curve, but that doesn't directly impact the changes here so this can be merged as is. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to hear sound while setting up the node.
Since this changes the default value, this may break existing projects slightly.
This also tweaks the Unit Size editor property hint for better usability.
See discussion in #25468 (comment).