Fix debugger not getting focused on break on Windows (3.2) #40555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a revert of 9d78274, which was an attempt to fix godotengine#21431, but in the end it seems a different problem was the root of the issue. Renewing focus steal allowance every time is needed on Windows.
RandomShaper
changed the title
|
Did you confirm that the revert does not reintroduce #21431? It was not the full fix but maybe part of the solution? |
|
@Calinou has helped testing this, now that I'm away from my Windows PC. It seems this PR doesn't revive the other bug. Ready to go! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revert of 9d78274, which was an attempt to fix #21431, but in the end it seems a different problem was the root of the issue.
Renewing focus steal allowance every time is needed on Windows.
A version for master is not needed since there the approach is different and seemingly already correct.