Provide support for buttons and D-pads mapped to half axes. #42799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2020
madmiraal
force-pushed
the
fix-41065
branch
2 times, most recently
from
fd04de0
to
f77db66
Compare
|
Updated to include a fix for axes mapped to buttons and D-pads and mappings to negative half-axes not working. |
madmiraal
force-pushed
the
fix-41065
branch
5 times, most recently
from
9bf16cc
to
59b7913
Compare
fix axes mapped to buttons and D-pads.
|
Updated to include fix for bug causing D-Pad buttons to stick. |
akien-mga
approved these changes
Oct 26, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#38151 (and the 3.2 non-compat breaking version #38724) provided support for half axes and inverted axes, but they did not implement support for buttons or D-pads mapped to half axes. Worse, D-pad inputs are expected to be mapped to buttons; so break when they're not. This PR provides support for mapping buttons and D-pads to half axes.
Should fix #41065, but I don't have a controller that has this kind of mapping; so it needs testing.