Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Camera3D near and far getters and setters #44434

Merged

Conversation

madmiraal
Copy link
Contributor

As originally identified here, Camera3D's near and far properties' getters and setters don't match the property name.

This PR renames the Camera3D's methods:

  • get_znear() -> get_near()
  • set_znear() -> set_near()
  • get_zfar() -> get_far()
  • set_zfar() -> set_far()

Part of #16863.

Renames:
- get_znear() -> get_near()
- set_znear() -> set_near()
- get_zfar() -> get_far()
- set_zfar() -> set_far()
@madmiraal
Copy link
Contributor Author

Rebased following merge of #33207.

@akien-mga akien-mga merged commit 8f4c4bb into godotengine:master Dec 28, 2020
@akien-mga
Copy link
Member

Thanks!

@bruvzg
Copy link
Member

bruvzg commented Dec 28, 2020

Something went wrong.

modules/gltf/gltf_document.cpp:4891:25: error: no member named 'get_zfar' in 'Camera3D'; did you mean 'get_far'?
                c->set_zfar(p_camera->get_zfar());
                                      ^~~~~~~~
                                      get_far
./scene/3d/camera_3d.h:124:8: note: 'get_far' declared here
        float get_far() const;
              ^
modules/gltf/gltf_document.cpp:4892:26: error: no member named 'get_znear' in 'Camera3D'; did you mean 'get_near'?
                c->set_znear(p_camera->get_znear());
                                       ^~~~~~~~~
                                       get_near
./scene/3d/camera_3d.h:125:8: note: 'get_near' declared here
        float get_near() const;
              ^
modules/gltf/gltf_document.cpp:4895:25: error: no member named 'get_zfar' in 'Camera3D'; did you mean 'get_far'?
                c->set_zfar(p_camera->get_zfar());
                                      ^~~~~~~~
                                      get_far
./scene/3d/camera_3d.h:124:8: note: 'get_far' declared here
        float get_far() const;
              ^
modules/gltf/gltf_document.cpp:4896:26: error: no member named 'get_znear' in 'Camera3D'; did you mean 'get_near'?
                c->set_znear(p_camera->get_znear());
                                       ^~~~~~~~~
                                       get_near
./scene/3d/camera_3d.h:125:8: note: 'get_near' declared here
        float get_near() const;

@madmiraal madmiraal deleted the rename-camera3d-near-and-far branch December 29, 2020 08:13
@madmiraal
Copy link
Contributor Author

For the record: Should have been rebased after merging #34193. Fixed with #44758.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants