Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CTL] Fix RTL scrolling and tabs selection. #44487

Merged
merged 4 commits into from
Dec 23, 2020

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Dec 18, 2020

@bruvzg bruvzg added this to the 4.0 milestone Dec 18, 2020
@akien-mga
Copy link
Member

I got that style issue too, it seems clang-format 11 changed its logic and produces a different result than 10 (used on CI): https://github.com/godotengine/godot/pull/44487/checks?check_run_id=1575457339

For now I've went with the git commit --no-verify approach to bypass pre-commit hooks and keep the clang-format 10 formatting, but eventually we should bump the version used on CI and have all contributors upgrade.

@bruvzg
Copy link
Member Author

bruvzg commented Dec 18, 2020

it seems clang-format 11 changed its logic and produces a different result than 10

Probably, I have clang-format 11 used in the git hook, and had similar styling issues with mismatching clang-format version in the past.

@bruvzg bruvzg marked this pull request as ready for review December 21, 2020 11:25
@akien-mga akien-mga merged commit 8ad0ff8 into godotengine:master Dec 23, 2020
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants