Draw a "background" line behind the dashed line in TextureRegion editor #45164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
cherrypick:3.x
This makes the dashed line visible on any background.
Calinou
force-pushed
the
texture-region-editor-line-background
branch
from
15848af
to
656aba1
Compare
KoBeWi
approved these changes
Jan 13, 2021
There was a problem hiding this comment.
It appears when you use ninepatches
Looks ok, although I'm not a fan of one-argument lines. If anything I'd do
edit_draw->draw_line(from, from + line,
EditorNode::get_singleton()->get_theme_base()->get_theme_color("mono_color", "Editor"),
Math::round(2 * EDSCALE));
But your formatting is ok too I guess.
|
Thanks! |
|
Cherry-picked for 3.2.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the dashed line visible on any background and also scales the line width on hiDPI displays.
This closes godotengine/godot-proposals#2113.
Note: I couldn't test this since I always forget how to display the dashed line in the TextureRegion editor.