Revert "Fix flicker in control nodes due to pivot offset"

[akien-mga]

Reverts #46409

Fixes #46850.

See #46409 (comment) for details.

Users who need this fix can try to disable gui/common/snap_controls_to_pixels which should be equivalent. It may however cause other regressions, which is why we're reverting this for now and we'll investigate further for a more thorough fix in 3.2.5 (hopefully!).

[calumk]

Just a quick note to say disabling "gui/common/snap_controls_to_pixels" does not seem to fix this for me, but on further inspection, it may not be as simple as i thought.

The error is not everywhere in the game, just in specific places, and there is a difference between 3.2.4rc3 and 3.2.4rc4, but it seems to only affect the editor.

The attached screenshot shows rc3 (left) and rc4 (right)

As you can see, in rc4, the editor text is appearing blurry, in rc3, its sharp and clear.

When actually running the game, both export the same, with a mixture of blurry and non-blurry text.
If I start a fresh project, I cannot seem to duplicate this behaviour, so it could be some setting i have toggled somewhere, but for the life of me i cant work out what.
I would put this down to my user error, except for the fact that the rc4 editor is now blurry for me, when in rc3 it was not, so something must have changed to cause this behaviour.

[akien-mga]

@calumk What you describe is what this PR is fixing. This was caused by the changes to scroll_container.cpp reverted in this PR.

Disabling gui/common/snap_controls_to_pixels is not a way to fix the regression in 3.2.4 RC 4, it's a way to fix the original issue that #46409 was trying to address.

[calumk]

Many thanks @akien-mga,
I look forward to rc5 :)