Add a menu action to open C++ source on GitHub in the editor debugger #47990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
cherrypick:3.x
akien-mga
reviewed
Apr 18, 2021
Calinou
force-pushed
the
editor-debugger-open-cpp-source-on-github
branch
from
d634e99
to
1a0ec41
Compare
fire
approved these changes
Apr 19, 2021
This helps user find back the source code where the error/warning was emitted from.
Calinou
force-pushed
the
editor-debugger-open-cpp-source-on-github
branch
from
1a0ec41
to
5bc746e
Compare
akien-mga
approved these changes
Apr 20, 2021
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps user find back the source code where the error/warning was emitted from.
I've tested this both with engine-emitted errors and user-emitted errors (
push_error()in GDScript), and it seems to work successfully so far.Preview
The action brings you to
https://github.com/godotengine/godot/blob/0ee744ff5f3cf045a2699aa4111de3200b9d70be/core/variant/variant_utility.cpp#L597.