Hide unsupported features in the web editor #49540
Conversation
Calinou
changed the title
Calinou
force-pushed
the
web-editor-hide-unsupported-features
branch
from
b5041b8
to
4c959ad
Compare
|
That makes sense, though I'm not fond of having so many hardcoded defines for a given platform in editor code. WDYT @Faless? |
I feel the same... Can we monkey patch the options via the editor tool javascript plugin? Maybe it's worse... In any case, we don't need the |
I needed those to avoid a crash or mismatched option indexes when the JavaScript platform was active. |
Calinou
force-pushed
the
web-editor-hide-unsupported-features
branch
from
4c959ad
to
b435249
Compare
Calinou
force-pushed
the
web-editor-hide-unsupported-features
branch
2 times, most recently
from
88ef5a5
to
1378f90
Compare
|
@akien-mga Was there a reason this was limboed? |
|
See the above discussion, neither @Faless nor myself really like the way this is done. |
|
In the end we went for the same hacky approach for the Android editor to fill the editor code with Should be rebased / retested so we can review further (though the Web editor still doesn't start right now so you might want to wait for that). Moving to 4.x milestone as not urgent, but if it's ready to merge during the 4.0 beta phase it should be good to go. |
The game camera override button is disabled with a tooltip explaining why, but other menu options are hidden entirely to prevent them from being listed in the list of available editor shortcuts. The Scan button is hidden as it serves no purpose in the web project manager. There is no way to import multiple project folders at once to the virtual HTML5 filesystem.
Calinou
force-pushed
the
web-editor-hide-unsupported-features
branch
from
1378f90
to
9b2c05d
Compare
| @@ -6831,20 +6843,28 @@ EditorNode::EditorNode() { | |||
| settings_menu->add_submenu_item(TTR("Editor Layout"), "Layouts"); | |||
| settings_menu->add_separator(); | |||
|
|
|||
| #if !defined(WEB_ENABLED) && !defined(ANDROID_ENABLED) | |||
There was a problem hiding this comment.
This wasn't excluded on Android. Did you check if it works?
| #ifdef WEB_ENABLED | ||
| // Scan function is not relevant on the web editor, as there is no way | ||
| // to import multiple projects at once into the virtual HTML5 filesystem. | ||
| scan_btn->hide(); | ||
| #endif |
There was a problem hiding this comment.
Did you test importing a zip with multiple projects in subfolders?
There was a problem hiding this comment.
I've just tried this in 4.0.beta2. It only imports the first project that is found in the ZIP. It'd be nice to implement support for importing multiple projects in a single ZIP (either at top-level or within a subfolder).
The game camera override button is disabled with a tooltip explaining why, but other menu options are hidden entirely to prevent them from being listed in the list of available editor shortcuts.
The Scan button is hidden as it serves no purpose in the web project manager. There is no way to import multiple project folders at once to the virtual HTML5 filesystem.
This pull request can be remade on the
3.xbranch once we agree on its design.