Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport pseudolocalization to 3.x #51404

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

angad-k
Copy link
Contributor

@angad-k angad-k commented Aug 8, 2021

(cherry picked from commit e79dde1)

Backport of pseudolocalization to 3.x. See #49361

@angad-k angad-k requested review from a team as code owners August 8, 2021 19:18
@Calinou Calinou changed the title backport pseudolocalization to 3.0 Backport pseudolocalization to 3.x Aug 8, 2021
@Calinou Calinou added this to the 3.4 milestone Aug 8, 2021
@Calinou
Copy link
Member

Calinou commented Aug 8, 2021

I tested this pull request. It works well in the editor, but some consonants are missing in the running project I tested.

Also, this is unrelated to the backport, but shouldn't the default pseudolocalization prefixes and suffixes be changed to [!!! and !!!] to match the editor's pseudolocalization debug feature?

Editor

2021-08-08_22 24 13

Game's main menu

2021-08-08_22 24 38

Game's options menu

2021-08-08_22 24 47

Game's first level

2021-08-08_22 24 57

@bruvzg
Copy link
Member

bruvzg commented Aug 8, 2021

fake_bidi can be removed, 3.x do not have any BiDi support, so it won't do anything.

@angad-k angad-k force-pushed the pseudolocalization-3.x branch 3 times, most recently from 8715203 to d5ee70b Compare August 9, 2021 08:14
@angad-k
Copy link
Contributor Author

angad-k commented Aug 9, 2021

I tested this pull request. It works well in the editor, but some consonants are missing in the running project I tested.

@Calinou I think the font doesn't support the extra glyphs. This is the output on Noto Sans.
image

Also, this is unrelated to the backport, but shouldn't the default pseudolocalization prefixes and suffixes be changed to [!!! and !!!] to match the editor's pseudolocalization debug feature?

Yup. I'll make that change.

@akien-mga
Copy link
Member

I tested this pull request. It works well in the editor, but some consonants are missing in the running project I tested.

I think the font doesn't support the extra glyphs. This is the output on Noto Sans.

Note that in master, missing glyphs should properly be identified as such. But indeed in 3.x they're simply invisible. That's not a priority to fix unless someone is really interested, since it's fixed in 4.0 already.

@bruvzg
Copy link
Member

bruvzg commented Aug 9, 2021

I think the font doesn't support the extra glyphs. This is the output on Noto Sans.

3.x might also fail to compose these characters, in case font only have separate base glyph and combining diacritic glyph.

(cherry picked from commit e79dde1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants