Implement OS::get_locale_language() helper method
#52740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method extracts the 2 or 3-letter language code from `OS::get_locale()`, making it easier for users to identify the "main" language code for users that might have different OS locales due to different OS or region, but should be matched to the same translation (e.g. "generic" Spanish). Fixes godotengine#40703.
akien-mga
added
enhancement
topic:core
cherrypick:3.x
|
Test on my system (Linux with print(OS.get_locale()) # en_DK
print(OS.get_locale_language()) # en |
|
Note to self: Before cherry-picking this for |
mhilbrunner
approved these changes
Sep 16, 2021
bruvzg
approved these changes
Sep 16, 2021
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method extracts the 2 or 3-letter language code from
OS::get_locale(),making it easier for users to identify the "main" language code for users
that might have different OS locales due to different OS or region, but
should be matched to the same translation (e.g. "generic" Spanish).
Fixes #40703.
Notes:
OSand not just tocore_bind::OSas I figured it could be useful for engine code or GDExtensions too. But strictly speaking it could be included only incore_bind::OSfor the binding if we want.TranslationServer, but it's actually more complex as it has to handle user-provided locale strings, while here we know that we'll get something reliable fromOS::get_locale().