Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Enable multithreaded OpenGL engine flag when using multithreaded VisualServer. #54526

Merged
merged 1 commit into from
Nov 8, 2021
Merged

[macOS] Enable multithreaded OpenGL engine flag when using multithreaded VisualServer. #54526

merged 1 commit into from
Nov 8, 2021

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 2, 2021

Fixes #54519

@bruvzg bruvzg added this to the 3.5 milestone Nov 2, 2021
@bruvzg bruvzg requested a review from a team as a code owner November 2, 2021 21:52
@Calinou Calinou added the crash label Nov 2, 2021
@akien-mga akien-mga merged commit 98a1e4f into godotengine:3.x Nov 8, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Nov 8, 2021
Closed
@bruvzg bruvzg deleted the opengl_mt branch November 9, 2021 05:43
@akien-mga
Copy link
Member

Cherry-picked for 3.4.1.

@bruvzg bruvzg mentioned this pull request Dec 18, 2021
Closed
@bruvzg bruvzg mentioned this pull request Dec 18, 2021
Closed
@bruvzg
Copy link
Member Author

bruvzg commented Dec 18, 2021

I have removed cherrypick:3.3 label, looks like this was a bad idea and causing multiple issues, see #56055 and #56060.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug crash platform:macos topic:rendering
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
3 participants
@bruvzg @akien-mga @Calinou