Enhance/fix some little things in Vulkan RD #55954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
commented
Dec 16, 2021
RandomShaper
force-pushed
the
vulkan_rd_goodies
branch
8 times, most recently
from
102c37b
to
ee580ba
Compare
RandomShaper
force-pushed
the
vulkan_rd_goodies
branch
2 times, most recently
from
46dc49d
to
4e23797
Compare
RandomShaper
force-pushed
the
vulkan_rd_goodies
branch
2 times, most recently
from
2f69ae9
to
0d9c76e
Compare
RandomShaper
force-pushed
the
vulkan_rd_goodies
branch
2 times, most recently
from
972fd78
to
b52f9a8
Compare
reduz
requested changes
Feb 6, 2022
| @@ -1963,7 +1963,7 @@ RID RenderingDeviceVulkan::texture_create(const TextureFormat &p_format, const T | |||
| image_memory_barrier.sType = VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER; | |||
| image_memory_barrier.pNext = nullptr; | |||
| image_memory_barrier.srcAccessMask = 0; | |||
| image_memory_barrier.dstAccessMask = VK_ACCESS_SHADER_READ_BIT; | |||
| image_memory_barrier.dstAccessMask = VK_ACCESS_SHADER_READ_BIT | VK_ACCESS_SHADER_WRITE_BIT; | |||
There was a problem hiding this comment.
I think we can fine grain a bit more here. SHADER_WRITE_BIT would make sense only of the storage usage bit is set.
If the texture has color buffer usage, then we can mask COLOR_ATTACHMENT_OUTPUT_BIT. Likewise, if it has depth stencil usage you can use EARLY_FRAGMENT_TESTS_BIT, and if it can be updated, then TRANSFER_BIT.
There was a problem hiding this comment.
I've removed the change and added instead a new commit with new logic for this barrier.
reduz
previously approved these changes
Feb 6, 2022
|
I think overall looks really good. I think the read/write hazzard fix may impose problems with barriers and my feeling is that this is a bug in the validation layer that we should discuss with Khronos. |
RandomShaper
force-pushed
the
vulkan_rd_goodies
branch
from
214739d
to
59f7bdb
Compare
RandomShaper
force-pushed
the
vulkan_rd_goodies
branch
2 times, most recently
from
377e05a
to
9696011
Compare
RandomShaper
force-pushed
the
vulkan_rd_goodies
branch
from
4d17177
to
aeb7686
Compare
RandomShaper
force-pushed
the
vulkan_rd_goodies
branch
from
aeb7686
to
aa27e32
Compare
RandomShaper
force-pushed
the
vulkan_rd_goodies
branch
from
aa27e32
to
f1e3aa3
Compare
RandomShaper
force-pushed
the
vulkan_rd_goodies
branch
3 times, most recently
from
0b67853
to
de7c456
Compare
RandomShaper
force-pushed
the
vulkan_rd_goodies
branch
6 times, most recently
from
21e8169
to
155174c
Compare
RandomShaper
force-pushed
the
vulkan_rd_goodies
branch
from
155174c
to
2652c95
Compare
reduz
requested changes
Jun 22, 2022
reduz
requested changes
Jun 22, 2022
reduz
approved these changes
Jun 27, 2022
|
Might need a rebase for good measure as last update was a month ago. |
- Initialize queue indices to values meaning 'unset' - Remove unused parameters & members - Make texture update access flags consistent with texture copy - Fix style and pass type of some parameters - Synchronize setup-draw in flush with a semaphore - Add no current list validation to draw_list_begin_splits() - Update texture usage flags on destination of copy - Fix misuse of Vulkan flag
RandomShaper
force-pushed
the
vulkan_rd_goodies
branch
from
2652c95
to
a82352c
Compare
|
Rebased and smoke re-tested! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've grouped most changes in a single commit since they were minimal. Others have been kept in separate commits as I think they are important enough to be tracked separately.
Commits
Apply some small fixes/enhancements to the Vulkan RD
Fix misuse of _buffer_memory_barrier()'s p_sync_with_draw parameterRemove superfluous pre Vector resize checks 🆕Fix passing dst stage mask only to single window semaphore in Vulkan RD(Removed since was done in another PR.)Optimize texture update in Vulkan RD
Stop debug time full barriers preventing layout transitions in Vulkan RD
Issue finer grained barrier on texture creation in Vulkan RDClear confusion between Vulkan and RD storage buffer usage values 🆕
Redefine RenderingDevice::BARRIER_MASK_NO_BARRIER to be 0 🆕Avoid manual memory management of certain arrays in Vulkan RD 🆕🆕