Add context menu to RichTextLabel #60170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
approved these changes
Apr 12, 2022
akien-mga
reviewed
Apr 12, 2022
scene/gui/rich_text_label.h
Outdated
| @@ -642,6 +667,7 @@ class RichTextLabel : public Control { | |||
| VARIANT_ENUM_CAST(RichTextLabel::AutowrapMode); | |||
| VARIANT_ENUM_CAST(RichTextLabel::ListType); | |||
| VARIANT_ENUM_CAST(RichTextLabel::ItemType); | |||
| VARIANT_ENUM_CAST(RichTextLabel::MenuItems); | |||
There was a problem hiding this comment.
This likely no longer needs to be exposed since _menu_option isn't.
bruvzg
reviewed
Apr 12, 2022
scene/gui/rich_text_label.cpp
Outdated
Comment on lines
4713
to
4716
|
|
||
| // Context Menu | ||
| BIND_ENUM_CONSTANT(MENU_COPY); | ||
| BIND_ENUM_CONSTANT(MENU_SELECT_ALL); |
akien-mga
reviewed
Apr 12, 2022
doc/classes/RichTextLabel.xml
Outdated
| @@ -607,6 +626,12 @@ | |||
| <constant name="VC_GLYPHS_RTL" value="4" enum="VisibleCharactersBehavior"> | |||
| Displays [member percent_visible] glyphs, starting from the right. | |||
| </constant> | |||
| <constant name="MENU_COPY" value="0" enum="MenuItems"> | |||
There was a problem hiding this comment.
These should also be removed since they were unexposed.
akien-mga
approved these changes
Apr 12, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RichTextLabel has the option to enable text selection so it could be useful to have a context menu.