Add Gradient resource preview generator #60395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geometror
changed the title
Geometror
force-pushed
the
editor-gradient-preview-plugin
branch
from
0320c6d
to
64b3d2f
Compare
|
How does it look when the inspector is narrower? |
|
@clayjohn It fills the width of the preview space. GradientTexture1D also does this.
|
fire-forge
approved these changes
Apr 20, 2022
| @@ -90,7 +90,8 @@ void EditorResourcePicker::_update_resource_preview(const String &p_path, const | |||
| if (p_preview.is_valid()) { | |||
| preview_rect->set_offset(SIDE_LEFT, assign_button->get_icon()->get_width() + assign_button->get_theme_stylebox(SNAME("normal"))->get_default_margin(SIDE_LEFT) + get_theme_constant(SNAME("hseparation"), SNAME("Button"))); | |||
|
|
|||
| if (Ref<GradientTexture1D>(edited_resource).is_valid()) { | |||
| // Ressource-specific stretching. | |||
| if (Ref<GradientTexture1D>(edited_resource).is_valid() || Ref<Gradient>(edited_resource).is_valid()) { | |||
There was a problem hiding this comment.
It would be nice to make stretching be defined by EditorResourcePreviewGenerator instead of hardcoding the resources, so that plugins can add stretching previews for custom resources too. But that can be done in another PR.
There was a problem hiding this comment.
You're right, I thought of this too, but this PR is just for adding the preview. I actually plan to refactor the resource preview system (as there are also some other small issues) sometime in the following weeks, it's already on my to-do list :)
Geometror
force-pushed
the
editor-gradient-preview-plugin
branch
from
64b3d2f
to
a93834c
Compare
akien-mga
approved these changes
Apr 26, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a resource preview generator for the
Gradientresource, which is quite helpful when working withGradients separate fromGradientTexture1D/2D. Having the resource expanded in the inspector takes up a lot of space and makes it more chaotic when you just wan't to see how the gradient looks like. (Also useful for saved gradient resources)Examples:
FastNoiseLite
CPUParticles2D/3D
Resource preview in FileSystem dock:
