Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak visibility editor icons to be more compact #62419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tweak visibility editor icons to be more compact #62419

wants to merge 1 commit into from
+3 −3

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jun 26, 2022 •
edited
Loading

The sclera area at the top/bottom of the eye icons is now smaller, making the scene tree dock look less cluttered.

See godotengine/godot-proposals#4718 (comment).

Preview

Before After
image image

@Calinou Calinou requested a review from a team as a code owner June 26, 2022 01:41
@Calinou Calinou added this to the 4.0 milestone Jun 26, 2022
@YuriSizov YuriSizov modified the milestones: 4.0, 4.1 Feb 9, 2023
@YuriSizov YuriSizov modified the milestones: 4.1, 4.2 Jun 14, 2023
@MewPurPur
Copy link
Contributor

I find it too similar to an oval now. May I suggest this? <svg height="16" viewBox="0 0 16 16" width="16" xmlns="http://www.w3.org/2000/svg"><path d="M8 3C5.5 3 2.5 4 1.05 7.7a1 1 0 0 0 0 .6C2.5 12 5.5 13 8 13s5.5-1 6.95-4.7a1 1 0 0 0 0-.6C13.5 4 10.5 3 8 3zm0 1.25a3.75 3.75 0 1 1 0 7.5 3.75 3.75 0 0 1 0-7.5zM8 6a2 2 0 1 0 0 4 2 2 0 0 0 0-4z" fill="#e0e0e0"/></svg>

image

image

@Calinou @MewPurPur
Tweak visibility editor icons to be more compact
afd8662 
The sclera area at the top/bottom of the eye icons is now smaller,
making the scene tree dock look less cluttered.

Co-authored-by: MewPurPur <mew.pur.pur@abv.bg>
@Calinou Calinou force-pushed the editor-icons-visibility-smaller branch from 4a6027f to afd8662 Compare July 18, 2023 17:39
@Calinou
Copy link
Member Author

Calinou commented Jul 18, 2023

I've incorporated the SVG, added you as a co-author and updated the screenshots in OP.

@MewPurPur
Copy link
Contributor

MewPurPur commented Jul 18, 2023 •
edited
Loading

Yay! I could propose the corresponding XRay equivalent if this design is liked. But I'm personally indifferent...

+ It does look closer to an eye
– I don't like how the new one doesn't really represent how the button has a square hitbox

Not really feeling the reduced clutter much.

@Calinou
Copy link
Member Author

Calinou commented Jul 18, 2023

– I don't like how the new one doesn't really represent how the button has a square hitbox

To be fair, I think we shouldn't expect all icons to have a square-like appearance. In fact, it's often desired that the hitbox is larger than the actual icon to allow for some tolerance, especially for touch input.

@AThousandShips AThousandShips modified the milestones: 4.2, 4.3 Oct 26, 2023
@Mickeon
Copy link
Contributor

Mickeon commented Feb 16, 2024 •
edited
Loading

I just realised this has never been merged. Now it conflicts with the Xray.svg it seems...

I'm in favour of this, though! It's not exactly hard to miss this icon. You're going to see it prevalently, and stacked on top of one another, as well.

@akien-mga akien-mga modified the milestones: 4.3, 4.x Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement topic:editor
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.
6 participants
@Calinou @MewPurPur @Mickeon @akien-mga @YuriSizov @AThousandShips