Prevent HTTPRequest from polling invalid client #64472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
force-pushed
the
try-fixing-http-bug
branch
3 times, most recently
from
3826355
to
63378c2
Compare
Mickeon
force-pushed
the
try-fixing-http-bug
branch
from
361a0d2
to
a8906f5
Compare
|
Reworked this PR, somewhat. Now it returns early, and the HTTPRequest... request isn't even started if the ID is invalid. |
Calinou
added
cherrypick:3.x
|
Could you squash the commits? See PR workflow for instructions. |
|
As I do that, what would the most appropriate error be for this? |
Mickeon
force-pushed
the
try-fixing-http-bug
branch
from
a8906f5
to
9d0cf58
Compare
Faless
requested changes
Sep 5, 2022
Mickeon
force-pushed
the
try-fixing-http-bug
branch
from
9d0cf58
to
e5304b2
Compare
Mickeon
force-pushed
the
try-fixing-http-bug
branch
from
e5304b2
to
9e284f6
Compare
|
Cherry-picked for 3.6. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.5.1. |
akien-mga
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat fixes #60602
The reason why the error mentioned in the issue typically shows up in the first place is because HTTPRequest keeps polling its associated client. However, as a result of exceeding the maximum DNS requests, the client's resolving id is INVALID, but nothing seems to be done on the HTTPRequest's side to handle it, because the HTTPRequest doesn't know this happened.
Now, only this error show up (no edit on my part, this is appropriate):
HTTPClientTCP.
connect_to_host()now returns ERR_CANT_RESOLVE if the maximum number of DNS queries has been reached,and so does HTTPRequest.request().Need to update documentation, but I know ERR_BUSY isn't the most ideal error code (it's already used, too). I need someone to suggest an alternative.