Fix warp_mouse for transient windows, fix mouse jumping around when spinbox released

[Begah]

Problem

When using the spinbox on a transient window, releasing the mouse after a drag (to increase/decrease value) put the cursor in the wrong place.

bugshowcase-2022-08-18_16.09.52.mp4

At the same time, i also fixed a small annoyance: when releasing after drag, the cursor jumped around instead of appearing directly at the correct position

bugshowcase2-2022-08-18_16.10.47.mp4

(Those 2 problems where notices on Linux(Ubuntu) + X11, i don't know about the other os)

Reproduce the problems

To reproduce the problems, you need to create a simple editor plugin :

@tool
extends EditorPlugin

func _enter_tree():
	add_tool_menu_item("Test", test_panel.bind())
	
func _exit_tree():
	remove_tool_menu_item("Test")

func test_panel() -> void:
	var res_test = load("res://test.tscn")
	
	var window := Window.new()
	window.title = "Testing"
	window.wrap_controls = true
	window.transient = true
	window.always_on_top = false
	window.exclusive = true
	window.popup_window = true
	
	window.disable_3d = true
	
	var instance = res_test.instantiate()
	
	window.add_child(instance)
	window.min_size = instance.custom_minimum_size

	var base_control := get_editor_interface().get_base_control()
	base_control.add_child(window)
	window.popup_centered(window.min_size)

Then just create a simple test scene with a spinbox inside it, then try to drag to change the spinbox's value

Fix

The proposed fix in this commit fixes both of those problems, but changing warp_mouse to a virtual function will decrease performance a bit, but i seemed like the cleanest approach.

[Begah]

Anyone knows what the class_db.hpp:160:37: error: too many initializers for 'GDNativeExtensionClassCreationInfo'
error is during the linux build? Didn't get the error on my computer.

[bruvzg]

Anyone knows what the class_db.hpp:160:37: error: too many initializers for 'GDNativeExtensionClassCreationInfo'
error is during the linux build? Didn't get the error on my computer.

Rebase your PR to fix it (see https://docs.godotengine.org/en/stable/community/contributing/pr_workflow.html#the-interactive-rebase). There was a change to GDExtension API, it's unrelated to this PR, but CI is pulling the latest version of godot-cpp regardless of the version of GDExtension headers in your branch.

[Begah]

Anyone knows what the class_db.hpp:160:37: error: too many initializers for 'GDNativeExtensionClassCreationInfo'
error is during the linux build? Didn't get the error on my computer.

Rebase your PR to fix it (see https://docs.godotengine.org/en/stable/community/contributing/pr_workflow.html#the-interactive-rebase). There was a change to GDExtension API, it's unrelated to this PR, but CI is pulling the latest version of godot-cpp regardless of the version of GDExtension headers in your branch.

Of course! It should have been obvious, thanks alot!

[bruvzg]

Those 2 problems where notices on Linux(Ubuntu) + X11, i don't know about the other os)

Both issues are reproducible on macOS as well, so it's probably relevant for all platforms, and both issues are fixed by this PR.

Code seems fine, but need to account for single-window mode.

[akien-mga]

Thanks!