Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename editor run/pause/stop shortcuts and tooltips for consistency #64756

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Aug 22, 2022

The new naming better suits non-game applications and is more explicit.

See godotengine/godot-proposals#5223.

@Calinou Calinou added this to the 4.0 milestone Aug 22, 2022
@Calinou Calinou force-pushed the editor-rename-run-project-shortcuts branch from 6c72d43 to 83b59d5 Compare September 25, 2022 17:04
editor/editor_node.cpp Outdated Show resolved Hide resolved
The new naming better suits non-game applications and is more explicit.
@Calinou Calinou force-pushed the editor-rename-run-project-shortcuts branch from 83b59d5 to 74b324c Compare September 25, 2022 18:18
@akien-mga akien-mga merged commit 94d511f into godotengine:master Sep 26, 2022
@akien-mga
Copy link
Member

Thanks!

@h0lley
Copy link

h0lley commented Sep 26, 2022

looks like you missed

VariantWriter::write_to_string(ED_GET_SHORTCUT("editor/stop"), shortcut);

where I believe the editor stop shortcut is taken to be the same for stopping test play when the game/app is in focus.

would a separate issue be useful?

edit: nvm, I see you already fixed it in #66441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants